Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CR-7821 #212

Merged
merged 3 commits into from
Nov 29, 2021
Merged

CR-7821 #212

merged 3 commits into from
Nov 29, 2021

Conversation

elad-codefresh
Copy link
Contributor

No description provided.

@roi-codefresh
Copy link
Contributor

why do we need this?

@elad-codefresh
Copy link
Contributor Author

why do we need this?

we need to expose the CreateIfNotExist property so that it could be changed via cli flag

@roi-codefresh
Copy link
Contributor

I already have a wrapper around it in the cli @elad-codefresh
image

@elad-codefresh
Copy link
Contributor Author

yes, I'm aware of it and tried to utilize it for this purpose, but for this scenario it's problematic, as:

  1. the flag is parsed only after creating the clone options
  2. we can't create the gsCloneOpts only afterwards (after the flag is parsed)
  3. we can't currently edit that (currently private) property after gsCloneOpts is created

@roi-codefresh
Copy link
Contributor

np

@noam-codefresh noam-codefresh merged commit 54c869f into argoproj-labs:main Nov 29, 2021
@noam-codefresh noam-codefresh deleted the CR-7821 branch November 29, 2021 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noam-codefresh noam-codefresh noam-codefresh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elad-codefresh @roi-codefresh @noam-codefresh